[Webkit-unassigned] [Bug 88778] [CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88778


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152736|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2012-07-24 17:27:09 PST ---
(From update of attachment 152736)
View in context: https://bugs.webkit.org/attachment.cgi?id=152736&action=review

I didn't review the tests that carefully because I presume these are reworks of the tests you're removing.

> Source/WebCore/ChangeLog:17
> +        No new tests (OOPS!).

This line will prevent the patch from landing.  Can you update this to list the test that you've added?

> Source/WebCore/dom/WebKitNamedFlow.h:65
> +    virtual const AtomicString& interfaceName() const;
> +    virtual ScriptExecutionContext* scriptExecutionContext() const;

We've been adding the OVERRIDE keyword to overrides of these functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.