[Webkit-unassigned] [Bug 90019] [chromium] Add time spent painting to GPU benchmarking renderingStats() API.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 15:47:19 PDT 2012


--- Comment #29 from Dave Tu <dtu at chromium.org>  2012-07-24 15:47:22 PST ---
(From update of attachment 153930)
View in context: https://bugs.webkit.org/attachment.cgi?id=153930&action=review

Found out that I missed a method signature in ImageLayerChromium, so the LayerChromium method was being called instead of the overriden method. That was causing the layout test failures. Does the OVERRIDE macro not generate compile-time errors or warnings?

>>> Source/Platform/chromium/public/WebRenderingStats.h:35
>>> +    double totalRasterizeTime; // in seconds
>> nit: If I were writing this patch, I might have included the comment in the variable name:
>> totalPaintTimeInSeconds
> +1 we do this in other places with units such as Bytes suffixed onto variables.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list