[Webkit-unassigned] [Bug 92163] flexitems can overflow the flexbox due to rounding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92163





--- Comment #3 from Tony Chang <tony at chromium.org>  2012-07-24 15:18:29 PST ---
(In reply to comment #2)
> The problem might be the following code in RenderFlexibleBox::resolveFlexibleLengths:
> 
>             if (availableFreeSpace > 0 && totalFlexGrow > 0 && flexSign == PositiveFlexibility && isfinite(totalFlexGrow))
>                 childSize += static_cast<int>(lroundf(availableFreeSpace * child->style()->flexGrow() / totalFlexGrow));
>             else if (availableFreeSpace < 0 && totalWeightedFlexShrink > 0 && flexSign == NegativeFlexibility && isfinite(totalWeightedFlexShrink))
>                 childSize += static_cast<int>(lroundf(availableFreeSpace * child->style()->flexShrink() * preferredChildSize / totalWeightedFlexShrink));

That seems likely.  I'll see if I can track down the history of the lroundf usage.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.