[Webkit-unassigned] [Bug 92040] Disable delete from contextmenu on password fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92040


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153933|review?                     |review-
               Flag|                            |




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org>  2012-07-24 11:05:08 PST ---
(From update of attachment 153933)
View in context: https://bugs.webkit.org/attachment.cgi?id=153933&action=review

> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:178
> -    if (m_webView->focusedWebCoreFrame()->editor()->canDelete())
> +    // Delete is not currently available for password fields: Webkit bug 92040.
> +    if (m_webView->focusedWebCoreFrame()->editor()->canDelete() && !selectedFrame->selection()->isInPasswordField())

I don't think this is the right fix. We should be able to delete text in password fields.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.