[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #8 from Anton Obzhirov <a.obzhirov at samsung.com>  2012-07-24 09:05:50 PST ---
(From update of attachment 152986)
View in context: https://bugs.webkit.org/attachment.cgi?id=152986&action=review

>> Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:109
>> +        return;
> 
> This check seems unnecessary.

I'll remove it. By the way what is standard strategy in webkit to deal with failed memory allocations?

>> Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:121
>> +    }
> 
> Protecting this should not be necessary here, since we are not doing anything else after didOpenSocketStream's called.

ok

>> Source/WebKit2/UIProcess/WebPageProxy.cpp:375
>> +#endif
> 
> This doesn't look right... WebSocketServer::platform{Listen,Close} should already be called when appropriate, shouldn't they?

I don't think they are called, I need to check. Another reason was to start/stop the server if developer extras enabled/disabled via the menu.

>> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:38
>> +    if (path == "/") {
> 
> So, as I understand it, if the remote side asks for / we want to give it the default page, which is the inspector.html file, but we want any other resource requested to be delivered as is. I don't understand what the meta refresh is about; also, is there a reason why we are not delivering pagelist.json in a special-case like qt?

Meta refresh is to redirect page to http://trac.webkit.org/export/head/trunk/Source/WebCore/inspector/front-end/inspector.html?ws=ddd.ddd.ddd.ddd:2999/devtools/page/1 if there is only one page. Otherwise it will show the page with the list of links to 
http://trac.webkit.org/export/head/trunk/Source/WebCore/inspector/front-end/inspector.html?ws=ddd.ddd.ddd.ddd:2999/devtools/page/1
...
http://trac.webkit.org/export/head/trunk/Source/WebCore/inspector/front-end/inspector.html?ws=ddd.ddd.ddd.ddd:2999/devtools/page/[n]
.
The idea is to reuse latest web inspector resources from http://trac.webkit.org/export/head/trunk/Source/WebCore/inspector/front-end/. But from your comment below probably it is not a good idea.

>> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:50
>> +            url = "http://trac.webkit.org/export/head/trunk/Source/WebCore/inspector/front-end/inspector.html";
> 
> Hmm, no, we should use the locally installed file, not the one hosted in webkit.org.

The hosted one should have the latest updates/fixes, shouldn't it?

>> Source/WebKit2/UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp:87
>> +        portValue = 2999;
> 
> Why 2999? Is it the same one used by the other ports?

well it was mentioned here as an example : http://www.webkit.org/blog/1620/webkit-remote-debugging/.
Can be any value I suppose.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.