[Webkit-unassigned] [Bug 91850] add 7 bit strings capabilities to the v8 binding layer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 08:46:49 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91850





--- Comment #15 from Kentaro Hara <haraken at chromium.org>  2012-07-24 08:46:53 PST ---
(From update of attachment 154067)
This is a big (wonderful) change. Before looking into details, I'd like to confirm a couple of things. Would you describe the following points in ChangeLog?

- Performance impact. (Was the dom-attr.html result just a noise? WebKit performance tests can just catch 10%~ regression. So it is important to manually make sure that a doubtful patch never regresses performance. Please check Bindings/* and Dromaeo/dom-*)

- Memory benefit. (How much memory is saved by this patch? Let's take a couple of real-world websites or artificial benchmarks and measure the memory benefit.)

- Test coverage. (You mentioned that existing tests are already testing the call path of this patch. Would you list up some of them instead of writing "No new tests. Refactor - no new functionality."?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list