[Webkit-unassigned] [Bug 91592] [EFL] Highlight the element under mouse on web inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91592





--- Comment #2 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-24 04:38:28 PST ---
(From update of attachment 152947)
View in context: https://bugs.webkit.org/attachment.cgi?id=152947&action=review

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:110
> +    hideHighlight();

This looks a bit odd this way. Maybe we should move the code in hideHighlight() to a new invalidateView(inspectedView) method and call this new function is both highlight() and hideHighlight()? This would be more understandable for me.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:118
> +        WebCore::IntRect rect(0, 0, width, height);

I would create this as late as possible, that is to say: after the NULL page check.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:122
> +            page->mainFrame()->view()->invalidateRect(rect);

page->mainFrame()->view()->invalidateRect(WebCore::IntRect(0, 0, width, height)); ?

> Source/WebKit/efl/ewk/ewk_paint_context.cpp:181
> +        if (controller && controller->highlightedNode())

page->inspectorController() cannot return NULL so the first check is not needed. Use an ASSERT() instead if you want to be safe.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.