[Webkit-unassigned] [Bug 91957] [EFL] Add File Chooser Settings API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 24 02:08:26 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=91957
--- Comment #20 from Kihong Kwon <kihong.kwon at samsung.com> 2012-07-24 02:08:29 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > (In reply to comment #15)
> > > (From update of attachment 153943 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=153943&action=review
> > >
> > > Stupid question: How is the client support to use this API? Both the constructor and destructor are private and the patch does not introduce any where to retrieve the Ewk_File_Choose_Settings from somewhere else. In itself, the patch seems to add code but no real functionality. Am I missing something?
> >
> > Client can access this by run_open_panel to get attribute of panel.
>
> ewk_view_run_open_panel() is private as well. If you mean the run_open_panel callback on the Ewk_View, then I still don't get it because the definition looks like this:
>
> Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Eina_Bool allows_multiple_files, Eina_List *accept_types, Eina_List **selected_filenames);
>
> It does not use Ewk_File_Choose_Settings and your patch does not seem to make it use it either.
I would like to change prototype of run_open_panel. That is not enough to use file open dialog.(bug 91956)
>
> >
> > > > Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:65
> > > > + Vector<WTF::String>::const_iterator it = settings->fileChooserSettings.acceptMIMETypes.begin();
> > >
> > > As per coding style, you should avoid using iterators and use indexes instead.
> > >
> >
> > I didn't know about that, could you show me the url of guide?
>
> http://www.webkit.org/coding/coding-style.html
Thanks. I forgot them.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list