[Webkit-unassigned] [Bug 92069] IndexedDB: IDBTransaction::abort() should throw DOMException

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92069





--- Comment #3 from xingnan.wang at intel.com  2012-07-24 00:34:34 PST ---
(From update of attachment 153971)
View in context: https://bugs.webkit.org/attachment.cgi?id=153971&action=review

Hi Kentaro,
    Thanks for your so quick response.

>> Source/WebCore/ChangeLog:7
>> +
> 
> Please add the spec link to this ChangeLog.

All right.

>> Source/WebCore/ChangeLog:8
>> +        Update storage/indexeddb/resources/transaction-abort.js to cover this case.
> 
> In WebKit convention, we write this line like this:
> 
>     Test: storage/indexeddb/transaction-abort.html

Got it.

>> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:196
>> +void IDBTransaction::abort(ExceptionCode& ec)
> 
> We do not want two abort() methods if possible. How about just changing the current 'void abort()' to 'void abort(ExceptionCode& ec)'?

abort() also needs to be called internally without throw exception, so I add another abort(ExceptionCode& ec) for external calling. If I just change abort() to abort(ExceptionCode& ec), all the points of call abort() need to be modified.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.