[Webkit-unassigned] [Bug 91957] [EFL] Add File Chooser Settings API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91957





--- Comment #16 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-24 00:27:46 PST ---
(From update of attachment 153943)
View in context: https://bugs.webkit.org/attachment.cgi?id=153943&action=review

>> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:37
>> +#else
> 
> I don't like duplicating the constructor with a #ifdef here.

Yes, it is good to make new constructor.

>> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:67
>> +        mimetypes = eina_list_append(mimetypes, strdup((*it).utf8().data()));
> 
> I thought we prefered to use eina_stringshare in EFL port.

IIRC, ewk_intext.cpp was landed by you. If so, let's change this one in new bug.

http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_intent.cpp#L109

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:106
> +Ewk_File_Chooser_Settings* ewk_file_chooser_settings_new(const WebCore::FileChooserSettings& coreSettings)

I think this API doesn't need to have coreSettings. It is just enough to have *setting*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.