[Webkit-unassigned] [Bug 63244] [Qt] Fix tst_QWebPage::showModalDialog() API test

Tue Jul 24 00:23:38 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=63244

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152507|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2012-07-24 00:23:43 PST ---
(From update of attachment 152507)
Hmm, in principle this sounds okay to me. But the patch doesn't apply, it uses src/3rdparty/webkit as prefix. Did you make this patch against Qt 4.8? It sounds like it needs to be rebased against WebKit trunk.

The patch is also missing a ChangeLog entry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.