[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603





--- Comment #19 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-23 23:37:12 PST ---
(From update of attachment 153724)
View in context: https://bugs.webkit.org/attachment.cgi?id=153724&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:89
> +    m_cachedPermissions.add(String(domain), isAllowed);

Use String::fromUTF8() instead of String().

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:101
> +    m_cachedPermissions.add(String(ewk_security_origin_string_get(origin)), isAllowed);

ditto.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:34
> +    NotificationPresenterClientEfl(Evas_Object* view);

Missing *explicit* keyword.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:48
> +    void addToPermissionCache(const char* domain, bool isAllowed);

Use String class in WebCoreSupport layer.

> Source/WebKit/efl/ewk/ewk_view.cpp:110
> +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)

Don't you remove LEGACY_NOTIFICATIONS macro in this patch ?

> Source/WebKit/efl/ewk/ewk_view.cpp:773
> +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4520
> +    EWK_VIEW_SD_GET(ewkView, smartData);

Use EWK_VIEW_SD_GET_OR_RETURN.

> Source/WebKit/efl/ewk/ewk_view.cpp:4521
> +    EWK_VIEW_PRIV_GET(smartData, priv);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4532
> +    EWK_VIEW_SD_GET(ewkView, smartData);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4533
> +    EWK_VIEW_PRIV_GET(smartData, priv);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.