[Webkit-unassigned] [Bug 23346] Restore form control values to a wrong form

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23346


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #52 from Kent Tamura <tkent at chromium.org>  2012-07-23 23:24:23 PST ---
I made a major improvement of the feature recently, and I believe the restore feature is not bad now.  I'm closing this bug. If someone still have a problem, please file another bug and cc to me.

(In reply to comment #45)
> What is this feature?
>   The purpose of the feature is to restore user-input values without on-memory back-forward cache.
>    -> So, we should not restore values for non user-editable controls such as elements with no renderer, visibility:none style, read-only/disabled elements.

I didn't change this behavior. We saves almost all of form control values, including type=hidden.

>    -> We should restore for controls with autocomplete=off because users can edit them.

I don't change this behavior yet.

>    -> WebKit should fire 'change' events when values are restored because restoring is a kind of user-input.

I didn't do it. Because we restore form control state only during document parsing, and I'm not sure dispatching event would make sense in such case.

> What's wrong with the current implementation?
>   * Values are restored to unexpected controls.
>     This often happens for dynamically generated pages.
>     -> We should check page identity more strictly.  Currently we have queues for type-name pairs.  We should have stricter data structure such as a list of type-name.

Done.  We identify forms with form structure.

>   * Values are restored to dynamically-generated controls.

When we switched to HTML5 parser, this behavior was gone, and no one requested to fix it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.