[Webkit-unassigned] [Bug 91581] [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91581





--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-23 20:02:19 PST ---
(From update of attachment 153157)
View in context: https://bugs.webkit.org/attachment.cgi?id=153157&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:393
> +    EWK_VIEW_SD_GET(ewkView, smartData);

Use EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:394
> +    EWK_VIEW_PRIV_GET(smartData, priv);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:404
> +    ASSERT(!priv->evasGlSurface);

Though below condition check this again, should we use this ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:416
> +bool ewk_view_accelerated_compositing_mode_enter(Evas_Object* ewkView)

If possible, it is good to use *const* keyword.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:418
> +    EWK_VIEW_SD_GET(ewkView, smartData);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:419
> +    EWK_VIEW_PRIV_GET(smartData, priv);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:442
> +    }

Add an empty line.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:446
> +bool ewk_view_accelerated_compositing_mode_exit(Evas_Object* ewkView)

If possible, it is good to use *const* keyword.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:448
> +    EWK_VIEW_SD_GET(ewkView, smartData);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:449
> +    EWK_VIEW_PRIV_GET(smartData, priv);

ditto.

> Tools/MiniBrowser/efl/main.c:51
> +    "GPL",

AFAIK, WebKit is based on LGPL and Apple BSD. So, LGPL is more proper.

> Tools/MiniBrowser/efl/main.c:224
> +    ecore_app_args_set(argc, (const char**) argv);

s/(const char**)/(const char **)/g

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.