[Webkit-unassigned] [Bug 91694] [chromium] Add droppedFrameCount to renderingStats.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91694





--- Comment #11 from Dave Tu <dtu at chromium.org>  2012-07-23 18:01:49 PST ---
(From update of attachment 153356)
View in context: https://bugs.webkit.org/attachment.cgi?id=153356&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.h:76
>> +    // FIXME: After crbug.com/129674 lands, determine this threshold based on monitor refresh rate.
> 
> Did you file a bug? Reference the bug rather than the blocking bug.

Done.

>> Source/WebCore/platform/graphics/chromium/cc/CCRenderingStats.h:31
>> +    // FIXME: After landing crbug.com/137790, rename these to animationFrameCount and screenFrameCount.
> 
> File a bug and reference the bug, rather than reference the blocking bug.

Done.

>>> Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:32
>>> +#include "cc/CCFrameRateCounter.h"
>> 
>> It's kind of weird to me that CCSingleThreadProxy has to directly know about the fps counter.  Can you just wrap sourceAnimationFrameNumber and droppedFrameCount in CCLTHI member functions?
> 
> Good poitn. David, lets add a method on m_layerTreeHostImpl->renderingStats(CCRenderingStats&) and have the proxies just call through to that. Then we can have one place where we fill in the impl-side stats.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.