[Webkit-unassigned] [Bug 91322] WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91322


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153901|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-07-23 17:23:13 PST ---
(From update of attachment 153901)
View in context: https://bugs.webkit.org/attachment.cgi?id=153901&action=review

Thanks for catching this! Some nitpicks but otherwise good.

> Source/WebCore/ChangeLog:4
> +        WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame
> +        https://bugs.webkit.org/show_bug.cgi?id=91322

This bug currently affects TextureMapper only (since other ports of GraphicsLayer don't use this file). That should be portrayed in the bug description and Changelog.

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp:54
> +        return 1.0;

Use 1 instead of 1.0.

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp:57
> +    return shouldReverseAnimationValue(direction, iterationCount) ? 1.0 : 0;

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.