[Webkit-unassigned] [Bug 83045] Improve line breaking performance for complex text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83045





--- Comment #14 from nholbrook at apple.com  2012-07-23 16:48:29 PST ---
(In reply to comment #13)
> (From update of attachment 153881 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153881&action=review
> 
> Do we have data that indicates no additional cost when not using the complex text case?

Said simple test app has options to test both paths and I observed no regression when not using the complex text case.

> > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:70
> > +        , m_controller(adoptPtr(new ComplexTextController(&m_font, m_run, true)))
> 
> The use of a boolean here leads to not-all-that-readable code. What does true mean? In WebKit we normally avoid this, or used named enums for them, to prevent that problem.

Agreed, although this boolean argument predates this patch.

> > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:76
> > +        m_controller->advance(from, 0, true);
> 
> Same problem here with the boolean argument.

This one is my fault, I'll fix it.

> > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:78
> > +        m_controller->advance(from + len, 0, true);
> 
> And here.

Ditto.

As for the rest of the comments, I'll make the suggested changes. Thanks, Darin.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.