[Webkit-unassigned] [Bug 92040] Delete text from password does nothing, proposed fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92040


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153892|review?                     |review-
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2012-07-23 16:33:21 PST ---
(From update of attachment 153892)
View in context: https://bugs.webkit.org/attachment.cgi?id=153892&action=review

> Source/WebCore/editing/EditorCommand.cpp:1238
> -        return enabledCut(frame, event, source);
> +        return enabledInEditableText(frame, event, source);

If we're making this change, then we should just delete this function and replace the reference in createCommandMap by enabledInEditableText.
Now, according to http://trac.webkit.org/changeset/29300 which added this code, we'll end up enabling the delete in an empty text field by making this change
but that'll be a regression. r- because of this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.