[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implement color chooser proxy for EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #2 from Ryuan Choi <ryuan.choi at samsung.com>  2012-07-23 16:07:40 PST ---
(From update of attachment 153448)
View in context: https://bugs.webkit.org/attachment.cgi?id=153448&action=review

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.cpp:37
> +    endChooser(); // FIXME: Remove this. Call the ewk API to show color chooser after implemented.

If I am right, this patch looks not complete to support color chooser.

Why don't you implement all instead of temporal blocking?

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.h:60
> +#endif // ENABLE(INPUT_TYPE_COLOR)
> +

unnecessary empty line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.