[Webkit-unassigned] [Bug 91541] [BlackBerry] Move about: URL handling out of WebCore

Mon Jul 23 12:37:54 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=91541

Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153828|review?                     |review-
               Flag|                            |

--- Comment #11 from Rob Buis <rwlbuis at gmail.com>  2012-07-23 12:37:58 PST ---
(From update of attachment 153828)
View in context: https://bugs.webkit.org/attachment.cgi?id=153828&action=review

Looks good, still some issues.

> Source/WebKit/blackberry/ChangeLog:11
> +        Other changes: Remove about:version which makes little sense. Make about:memory partially visible.

Bu about:version is still in use.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:397
> +            WTF::RefPtr<SharedBuffer> buffer = SharedBuffer::create(source.is8Bit() ? reinterpret_cast<const char*>(source.characters8()) : source.latin1().data(), source.length());

No WTF:: prefix needed.

> Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:328
> +    } else if (equalIgnoringCase(aboutWhat, "cache")) {

We seem to be dealing with cache a lot, how about an if block for when aboutWhat starts with "cache" and then do the subtests?

> Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:344
> +        result.append(String("<html><head><title>BlackBerry Browser Disk Cache</title></head><body>Http disk cache is enabled.</body></html>"));

These two blocks are so similar that maybe a helper function can be added for them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.