[Webkit-unassigned] [Bug 91986] New: [CMake] Define constants in cmakeconfig.h instead of passing them directly via add_definitions()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91986

           Summary: [CMake] Define constants in cmakeconfig.h instead of
                    passing them directly via add_definitions()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rakuco at webkit.org


The amount of constants for paths and other values we are passing via ADD_DEFINITIONS(-DFOO=bar) in our build system files is increasing. This is not the correct approach -- a cleaner way of passing values from the build system to source files is by using #cmakedefine, #cmakedefine01 or #define and have CMake replace the desired values via CONFIGURE_FILE().

We need to extend cmakeconfig.h.cmake and have it perhaps #include a port-specific config.h file which should be responsible for having these definitions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.