[Webkit-unassigned] [Bug 91957] [EFL] Add File Chooser Settings API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91957





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-23 03:53:43 PST ---
(From update of attachment 153765)
View in context: https://bugs.webkit.org/attachment.cgi?id=153765&action=review

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:67
> +        mimetypes = eina_list_append(mimetypes, eina_stringshare_add((*it).utf8().data()));

I think it is good to use strdup(). Then, update API description.

See also : http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_intent.h#L50

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:79
> +        fileExtentions = eina_list_append(fileExtentions, eina_stringshare_add((*it).utf8().data()));

ditto.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:91
> +        files = eina_list_append(files, eina_stringshare_add((*it).utf8().data()));

ditto.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.h:110
> + * @return One of these string "camera", "camcorder", "microphone" or "filesystem" or @c NULL if there is not a proper file chooser settings scheme

Use lower case. s/One/one/g

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.