[Webkit-unassigned] [Bug 91957] [EFL] Add File Chooser Settings API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91957





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-23 01:19:34 PST ---
(From update of attachment 153747)
View in context: https://bugs.webkit.org/attachment.cgi?id=153747&action=review

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:64
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, 0);

I think you need to mention this API can return NULL in API description.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:68
> +    for (unsigned i = 0; i < acceptMIMETypes.size(); ++i) {

It looks below code is more clear than this.

http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_intent.cpp#L107

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:78
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, 0);

ditto.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:92
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, 0);

ditto.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:118
> +        , eina_stringshare_add(settings->fileChooserSettings->capture.utf8().data()

Please adhere indentation.

See also below,
http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_intent.cpp#L93

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.