[Webkit-unassigned] [Bug 89719] [EFL][WK2] ProcessExecutablePath is required

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89719





--- Comment #16 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-07-23 01:18:32 PST ---
(From update of attachment 153749)
View in context: https://bugs.webkit.org/attachment.cgi?id=153749&action=review

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:7
> +/*
> +    Copyright (C) 2012 Samsung Electronics
> +
> +    This library is free software; you can redistribute it and/or
> +    modify it under the terms of the GNU Library General Public
> +    License as published by the Free Software Foundation; either
> +    version 2 of the License, or (at your option) any later version.

Any reason to not use the default BSD license? It makes copying code around in WebKit and doing refactorings easier without having to worry about the license.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:32
> +static String findWebKitProcess(const char* processName)

WebKitProcess is kind of confusing. I would just call it findProcessPath()

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:46
> +        // check whether process exist on the current path

Start with capital, end with punctuation mark. Someone needs to make the style check check for this

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:56
> +String executablePathOfWebProcess()

findWebProcessPath() ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.