[Webkit-unassigned] [Bug 91957] [EFL] Add File Chooser Settings API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91957





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-23 00:46:22 PST ---
(From update of attachment 153743)
View in context: https://bugs.webkit.org/attachment.cgi?id=153743&action=review

I would like to know how many test cases can be covered by this patch.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:52
> +Eina_Bool ewk_file_chooser_settings_allows_directory_upload_get(const Ewk_File_Chooser_Settings *settings)

Nit : Move '*' to data type side.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:68
> +    for (unsigned i = 0; i < acceptMIMETypes.size(); i++) {

WebKit prefers to use ++i.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.cpp:82
> +    for (unsigned i = 0; i < acceptFileExtensions.size(); i++) {

ditto.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.h:32
> + * We can use these attributes by file chooser settings APIs.

I think "We can use these" is not proper API description.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.h:33
> + *

Nit : Unneeded line.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings.h:114
> +EAPI const char *ewk_file_chooser_settings_capture_get(const Ewk_File_Chooser_Settings* s);

Nit : Move '*' to variable side.

> Source/WebKit/efl/ewk/ewk_file_chooser_settings_private.h:29
> +void ewk_file_chooser_settings_free(Ewk_File_Chooser_Settings *o);

Nit : Do not abbreviation in internal functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.