[Webkit-unassigned] [Bug 91733] Destroy CSS decoded data more eagerly once they become dead caches.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 22 19:05:08 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91733





--- Comment #4 from Huang Dongsung <luxtella at company100.net>  2012-07-22 19:05:13 PST ---
(In reply to comment #3)
> (From update of attachment 153228 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153228&action=review
> 
> > Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:172
> > +        makePurgeable(true);
> 
> Where is the makePurgeable(false) call to balance this? That's a good thing to comment on in your ChangeLog.

Thank you for your review.

makePurgeable(false) is called by MemoryCache::resourceForURL() and DocumentLoader::subresource() like CachedImage and CachedScript.
CachedImage and CachedScript call only makePurgeable(true) instead of makePurgeable(false), too.
IMHO, "makePurgeable(false) call" may be not related to this patch because the previous CachedCSSStyleSheet did not call makePurgeable(false) and CachedCSSStyleSheet of this patch does also.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list