[Webkit-unassigned] [Bug 91912] Adding new value (atomic) for property (-webkit-user-select)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91912





--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-07-20 17:44:02 PST ---
Attachment 153631 did not pass style-queue:

Source/WebCore/css/CSSPrimitiveValueMappings.h:2351:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/editing/ReplaceSelectionCommand.cpp:1072:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/editing/ReplaceSelectionCommand.cpp:1073:  Missing spaces around ==  [whitespace/operators] [3]
Source/WebCore/editing/ReplaceSelectionCommand.cpp:1073:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/page/DragController.cpp:641:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/page/DragController.cpp:772:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/page/DragController.cpp:772:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/page/DragController.cpp:788:  Missing spaces around ||  [whitespace/operators] [3]
Source/WebCore/rendering/style/StyleRareInheritedData.h:89:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/editing/VisibleSelection.cpp:518:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/editing/VisibleSelection.cpp:518:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisibleSelection.cpp:523:  Missing space before ( in while(  [whitespace/parens] [5]
Source/WebCore/editing/VisibleSelection.cpp:523:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/editing/VisibleSelection.cpp:527:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisibleSelection.cpp:527:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/editing/VisibleSelection.cpp:540:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/editing/VisibleSelection.cpp:549:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/editing/VisibleSelection.cpp:551:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/editing/VisibleSelection.cpp:555:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/editing/VisibleSelection.cpp:557:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/editing/VisibleSelection.cpp:561:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/editing/VisibleSelection.cpp:562:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisibleSelection.cpp:565:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisibleSelection.h:119:  The parameter name "selection" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/editing/VisibleSelection.h:127:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/editing/FrameSelection.cpp:1845:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/FrameSelection.cpp:1847:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/visible_units.cpp:984:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/editing/visible_units.cpp:987:  Missing spaces around ==  [whitespace/operators] [3]
Source/WebCore/editing/visible_units.cpp:989:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/editing/visible_units.cpp:991:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/visible_units.cpp:991:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/editing/visible_units.cpp:1058:  Missing spaces around ==  [whitespace/operators] [3]
Source/WebCore/editing/visible_units.cpp:1060:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/editing/visible_units.cpp:1062:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/visible_units.cpp:1062:  An else statement can be removed when the prior "if" concFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/editing/selection/icon.png', u..." exit_code: 1
ludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/editing/VisiblePosition.cpp:65:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/editing/VisiblePosition.cpp:68:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:76:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:84:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/editing/VisiblePosition.cpp:84:  Missing space before ( in while(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:86:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/editing/VisiblePosition.cpp:87:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:95:  Missing space before ( in while(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:97:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/editing/VisiblePosition.cpp:98:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:106:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/editing/VisiblePosition.cpp:106:  Missing space before ( in while(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:108:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/editing/VisiblePosition.cpp:109:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:117:  Missing spaces around &&  [whitespace/operators] [3]
Source/WebCore/editing/VisiblePosition.cpp:117:  Missing space before ( in while(  [whitespace/parens] [5]
Source/WebCore/editing/VisiblePosition.cpp:119:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/editing/VisiblePosition.cpp:120:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/page/EventHandler.cpp:1299:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/page/EventHandler.cpp:1300:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebCore/page/EventHandler.cpp:1300:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 57 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.