[Webkit-unassigned] [Bug 91887] [BlackBerry] Add Cancel button for Select popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91887


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153556|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2012-07-20 12:15:29 PST ---
(From update of attachment 153556)
View in context: https://bugs.webkit.org/attachment.cgi?id=153556&action=review

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:151
> +    // "-1" means cancel.
> +    if (stringValue.contains("-1")) {

nit: I would remove the comment, and make the code self-explanatory :)

DEFINE_STATIC_LOCAL("-1", cancelValue)
if (string.contains(cancelValue)) {
    blah;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.