[Webkit-unassigned] [Bug 91766] didFirstVisuallyNonEmptyLayout() callback not fired for initial about:blank page in new loading window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91766





--- Comment #13 from Beth Dakin <bdakin at apple.com>  2012-07-20 11:20:46 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > Have you looked at dispatchDidNewFirstVisuallyNonEmptyLayout to see whether that works better for your use case?
> 
> Just took a look.  Good thought, but it isn't called when I modify the content of the initial document.  Other things I could check?

This heuristic will only kick in if you call Page::setRelevantRepaintedObjectsCounterThreshold(uint64_t threshold) to set a threshold for the number of relevant objects that have been painted. The code is in a very confusing state right now because the current implementation does not actually even use that number, it's just using the setting of that number to anything other than 0 as an indicator that the heuristic should run. See this comment in Page.cpp:

// FIXME: gPaintedObjectCounterThreshold is no longer used for calculating relevant repainted areas,
// and it should be removed. For the time being, it is useful because it allows us to avoid doing
// any of this work for ports that don't make sure of didNewFirstVisuallyNonEmptyLayout. We should
// remove this when we resolve <rdar://problem/10791680> Need to merge didFirstVisuallyNonEmptyLayout 
// and didNewFirstVisuallyNonEmptyLayout
static uint64_t gPaintedObjectCounterThreshold = 0;

Sorry so sloppy!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.