[Webkit-unassigned] [Bug 91850] add 7 bit strings capabilities to the v8 binding layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91850





--- Comment #7 from Dan Carney <dcarney at google.com>  2012-07-20 08:10:57 PST ---
(In reply to comment #4)
> (From update of attachment 153483 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153483&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        No new tests.  Refactor - no new functionality.
> 
> (I've not looked into the patch in detail but) would you check performance impact? We want to confirm that this change won't regress binding performance. You can test binding performance by WebKit/PerformanceTests/Dromaeo/dom-*.html and WebKit/PerformanceTests/Bindings/*. (You can add a new one if needed.)




I've run the performance tests for you.  No obvious degradation, but the one place I suspect there could be performance degradation String::containsOnlyASCII() I intend to fix upstream, so that the cost of calling that will be gone.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.