[Webkit-unassigned] [Bug 91844] [EFL][WK2] Plugin process implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844


Christophe Dumez <christophe.dumez at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.dumez at intel.com




--- Comment #5 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-20 07:31:01 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 153463 [details] [details])
> > Attachment 153463 [details] [details] did not pass efl-ews (efl):
> > Output: http://queues.webkit.org/results/13312188
> 
> I think that these errors are false positives. Situation looks like:
> 
> #if port(X)
> #include A,B,C
> #elsif port(Y)
> #include A,B
> 
> check-webkit-style reports duplication of includes in different excluding macros. What do you think about it?

You should probably use something like

#if PORT(X) || PORT(Y)
 #include A
 #include B
#endif

if PORT(X)
 #include C
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.