[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003





--- Comment #56 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-07-20 02:43:52 PST ---
(In reply to comment #54)
> (From update of attachment 151028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151028&action=review
> 
> Overall approach in JSC looks good. One comment below.
> 
> > Source/JavaScriptCore/parser/Parser.cpp:1639
> > +        expr = context.makePostfixNode(m_lexer->lastLineNumber(), tokenColumn(), expr, OpPlusPlus, subExprStart, lastTokenEnd(), tokenEnd());
> 
> It's awkward to get the line number from the lexer, but get the column number from the current token. Let's get all the data from the current token instead.
> 
> The smallest change you can make to fix this is to pass a reference to the current token instead of two separate numbers.
> 
> It would be even better to rename JSTokenInfo to TokenLocation, put line, column, start, end, and divot all in TokenLocation, and pass just that one object to all clients.

Thank you for your comments. I've updated a new patch according to your comments. There is only one exception that I didn't include divot in TokenLocation, since it will bring a lot of more modifications. I really want to keep the modification and risk of side-effect minimum, if the modification is acceptable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.