[Webkit-unassigned] [Bug 91607] Web Inspector: Protocol Extension: add getNamedFlowCollection command

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91607


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153444|                            |review-
               Flag|                            |




--- Comment #11 from Pavel Feldman <pfeldman at chromium.org>  2012-07-20 01:49:07 PST ---
(From update of attachment 153444)
View in context: https://bugs.webkit.org/attachment.cgi?id=153444&action=review

> Source/WebCore/dom/WebKitNamedFlowCollection.h:33
> +#include <InspectorBackendDispatcher.h>

You should not make arbitrary component depend on the inspector guts. Also, these are not visible in case of !ENABLED(INSPECTOR). You should return a Vector<String> instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.