[Webkit-unassigned] [Bug 91812] Implement UndoManager's automatic DOM transactions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91812





--- Comment #6 from Kentaro Hara <haraken at chromium.org>  2012-07-20 01:41:57 PST ---
(From update of attachment 153399)
View in context: https://bugs.webkit.org/attachment.cgi?id=153399&action=review

V8 change LGTM.

> Source/WebCore/bindings/js/JSUndoManagerCustom.cpp:90
> +        return throwTypeError(exec);

Let's make this message the same as the V8's one.

> Source/WebCore/bindings/js/JSUndoManagerCustom.cpp:104
> +    setDOMException(exec, ec);

if (ec) setDOMException(exec, ec);

> Source/WebCore/bindings/v8/custom/V8UndoManagerCustom.cpp:80
> +    ExceptionCode ec = 0;

Nit: This line should be just before imp->transact().

> Source/WebCore/bindings/v8/custom/V8UndoManagerCustom.cpp:84
> +        return V8Proxy::throwTypeError("Not an object.", args.GetIsolate());

Nit: I expected more descriptive message than "Not an object".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.