[Webkit-unassigned] [Bug 91537] [Chromium] Textures drawn during occlusion are incorrectly re-used when unoccluded.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91537


Adrienne Walker <enne at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153329|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #15 from Adrienne Walker <enne at google.com>  2012-07-19 13:19:28 PST ---
(From update of attachment 153329)
View in context: https://bugs.webkit.org/attachment.cgi?id=153329&action=review

R=me.  The tests are great.  :)

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:455
> +    if (hasOcclusionFromOutsideTargetSurface)
> +        *hasOcclusionFromOutsideTargetSurface = (intersection(unoccludedInScreen, unoccludedInTarget) != unoccludedInTarget);
> +
> +    if (unoccludedInScreen.isEmpty())
> +        return unoccludedInScreen;
> +
>      return intersection(unoccludedInScreen, unoccludedInTarget);

I don't think you need this second if statement.

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:512
> +    if (unoccludedInScreen.isEmpty())
> +        return unoccludedInScreen;
> +

Nor this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.