[Webkit-unassigned] [Bug 91742] check-webkit-style crashes with OSError exception if SVN is not installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91742





--- Comment #4 from Adam Barth <abarth at webkit.org>  2012-07-19 10:56:07 PST ---
(From update of attachment 153284)
View in context: https://bugs.webkit.org/attachment.cgi?id=153284&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:97
> +            exit_code = Executive().run_command(svn_info_args, cwd=path, return_exit_code=True)
> +        except OSError:
> +            return False
>          return (exit_code == 0)

Does this work?  The way Python scoping works exit_code will be limited in scope to just the "try" block and won't be available during the return statement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.