[Webkit-unassigned] [Bug 91731] [EFL][WK2][WTR] Implement EventSenderProxy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91731





--- Comment #5 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-19 09:48:22 PST ---
(From update of attachment 153243)
View in context: https://bugs.webkit.org/attachment.cgi?id=153243&action=review

> Tools/WebKitTestRunner/EventSenderProxy.h:98
> +    void sendOrQueueEvent(WTREvent);

Pass by const reference instead of by value?

> Tools/WebKitTestRunner/EventSenderProxy.h:99
> +    void dispatchEvent(WTREvent);

Ditto.

> Tools/WebKitTestRunner/EventSenderProxy.h:124
> +    Vector<WTREvent> m_eventQueue;

You only push_back() and pop_front() on this container. Vector is definitely not the best container for this. How about a WTF::Deque? it has O(1) for pop_front() and push_back().

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:84
> +    int vertical;

Would add a blank line after this.

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:85
> +    WTREvent()

modifiers, horizontal and vertical are not initialized.

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:90
> +    }

Would add a blank line after this.

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:91
> +    WTREvent(WTREventType eventType, unsigned delay, WKEventModifiers modifiers, int button)

horizontal and vertical are not initialized.

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:128
> +    for (unsigned modifier = 0; modifier < 4; ++modifier) {

can we use sizeof(modifierNames)/sizeof(char*) instead of 4 here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.