[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 04:36:33 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-07-19 04:36:32 PST ---
Attachment 153226 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/Change..." exit_code: 1
Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:56:  MAX_BUFFER is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:57:  MAX_PROCESS_PATH is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list