[Webkit-unassigned] [Bug 91058] Modifying an attribute for which there is a selector in html.css does not cause a style recalc

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 02:12:29 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91058


Matt Falkenhagen <falken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152167|0                           |1
        is obsolete|                            |




--- Comment #5 from Matt Falkenhagen <falken at chromium.org>  2012-07-19 02:12:27 PST ---
Created an attachment (id=153211)
 --> (https://bugs.webkit.org/attachment.cgi?id=153211&action=review)
better testcase that uses <pre> and <code> instead of <span>

I discovered the previous testcase was bad since <span> uses the simple default style in StyleResolver.cpp (elementCanUseSimpleDefaultStyle() returns true).

I've modified the testcase to use <pre> and <code> instead. In this test case, an attribute selector pre[open] is defined in html.css and a code[open] one is defined in the layout test itself. When I run the test, <pre>'s does not take effect, but <code>'s does.

I found that changing elementCanUseSimpleDefaultStyle() to always return false seems to fix the bug, but I'm not sure that is the real cause. If elementCanUseSimpleDefaultStyle() is not changed and instead the pre[open] CSS is simply added to the simpleUserAgentStyleSheet string, the bug still occurs.

It seems it is some timing issue of when the stylesheet is read. It seems if I run a fresh instance of Chromium and immediately open the layout test, it fails, but if I then reload or open the test by clicking a link to it, it passes. Also, running other layout tests before this one causes it to pass; it only fails if it's the only test run.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list