[Webkit-unassigned] [Bug 90019] [chromium] Add time spent painting to GPU benchmarking renderingStats() API.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 01:32:23 PDT 2012


--- Comment #10 from Nat Duca <nduca at chromium.org>  2012-07-19 01:32:22 PST ---
(From update of attachment 152358)
View in context: https://bugs.webkit.org/attachment.cgi?id=152358&action=review

I'm happy. Enne?

> Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:-98
> -    SkPictureCanvasLayerTextureUpdater::prepareToUpdate(contentRect, tileSize, contentsWidthScale, contentsHeightScale, resultingOpaqueRect);

I think this class' prepareRect time spent in updater->paintContentsRect should increment timePainting. While you're at it, add a timeSpentRasterizing property to the stats that is separate that we bump when this class does drawPicture, lower in the file.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:218
> +    ++m_renderingStats.numAnimationFrames;

why ++x and not x++? Does webkit style guide advise on this?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list