[Webkit-unassigned] [Bug 90675] Web Inspector: implement testing harness for pure protocol tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90675





--- Comment #12 from Vivek Galatage <vivekgalatage at gmail.com>  2012-07-19 01:06:24 PST ---
Thank you Pavel for your feedback. One question I have as below - 

> > boolean Internals::openDummyInspectorFrontend() {
> >     Page::PageClients pageClients;
> >     pageClients.chromeClient = 0;
> >     pageClients.contextMenuClient = 0;
> >     pageClients.editorClient = 0;
> >     pageClients.dragClient = 0;
> >     pageClients.inspectorClient = 0;
> >     m_page = new Page(pageClients); 
> > 
> >     m_frontendClient = new InspectorFrontendClientDummy(...); 
> > 
> >     m_page->inspectorController()->setInspectorFrontendClient(m_frontendClient);
> > 
> >     m_frontendChannel = new InspectorFrontendChannelDummy(...);
> 
> You should not need to do this as long as you instantiate InspectorFrontendClientLocal with the right Page* frontendPage instance that you create. Then you just pass its instance into the connectFrontend.

So are you hinting at InspectorFrontendClientDummy inheriting both InspectorFrontendClientLocal as well as InspectorFrontendChannel and keeping a raw pointer to the Page* for the frontend?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.