[Webkit-unassigned] [Bug 91688] [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91688





--- Comment #3 from Adrienne Walker <enne at google.com>  2012-07-18 18:51:05 PST ---
(From update of attachment 153127)
View in context: https://bugs.webkit.org/attachment.cgi?id=153127&action=review

This patch is great.  I really like the switch from pulling information from layers to pushing it there.

> Source/WebCore/page/FrameView.cpp:652
> +#if OS(ANDROID)
> +    if (m_frame->page()->mainFrame() == m_frame) {
> +        if (hMode == ScrollbarAuto)
> +            hMode = ScrollbarAlwaysOn;
> +        if (vMode == ScrollbarAuto)
> +            vMode = ScrollbarAlwaysOn;
> +    }
> +#endif

Is there a better place for this? How do other ports set the kind of scrollbars they want?

> Source/WebCore/platform/graphics/chromium/cc/CCScrollbarAnimationControllerAndroid.h:34
> +    CCScrollbarAnimationControllerAndroid(CCLayerImpl* scrollLayer);

1-arg ctor needs the explicit keyword.  Can you also make a create function that returns a PassOwnPtr?

> Source/WebCore/platform/graphics/chromium/cc/CCScrollbarAnimationControllerAndroid.h:40
> +    virtual bool animate(double monotonicTime);
> +    virtual void didPinchGestureUpdate();
> +    virtual void didPinchGestureEnd();
> +    virtual void updateScrollOffset(CCLayerImpl* scrollLayer);

OVERRIDE

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.