[Webkit-unassigned] [Bug 91690] JSC: bug fixes and enhancements for OfflineASM annotation system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91690


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153132|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Filip Pizlo <fpizlo at apple.com>  2012-07-18 17:28:14 PST ---
(From update of attachment 153132)
View in context: https://bugs.webkit.org/attachment.cgi?id=153132&action=review

> Source/JavaScriptCore/offlineasm/parser.rb:94
> +            annotationType = whitespaceFound ? "@L" : "@G" # local or global annotation

It is customary to use symbols (:thing) rather than strings ("thing") for enumerating in ruby.

> Source/JavaScriptCore/offlineasm/parser.rb:99
> -                result << Token.new(CodeOrigin.new(fileName, lineNumber), "@" + annotation)
> +                result << Token.new(CodeOrigin.new(fileName, lineNumber),
> +                                    "#{annotationType}#{annotation}")

I don't like the idea of using strings with magic as the contents of a token.  Tokens are supposed to contain the string that was parsed.  We already have a slightly ugly hack for numbers (we convert the string to a number then back to a decimal string) but I don't want that to spread.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.