[Webkit-unassigned] [Bug 90734] [GStreamer] usec rounding is wrong during accurate seeking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90734





--- Comment #4 from Philippe Normand <pnormand at igalia.com>  2012-07-18 07:06:19 PST ---
(In reply to comment #3)
> Can you give an example of how this affects rounding? Before, 6.0272 was rounded to 6.03.

Yes. Example when running media/video-seek-past-end-playing.html

Seek to 6.027200: 6.000000 secs 30000 usecs
Seek: 0:00:06.030000000

> What is it rounded to now?

Now, same test with the patch:

Seek to 6.027200: 6.000000 secs 27200 usecs
Seek: 0:00:06.027200000

> Does this affect tests at all?

Yes, well with the patch media/video-frame-accurate-seek.html still passes.
The issue with the previous rounding "strategy" is that some values were correctly rounded and some not, as you can see above. Maybe I can update the layout test!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.