[Webkit-unassigned] [Bug 90084] [GStreamer] Live stream support is weak

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90084





--- Comment #11 from Philippe Normand <pnormand at igalia.com>  2012-07-18 06:43:26 PST ---
(In reply to comment #10)
> (From update of attachment 151155 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151155&action=review
> 
> I very much agree with the general direction of this patch. I had to do the same thing for the N9 :)
> 

Too bad I didn't see any patch in bugzilla! :/

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1434
> > +    if (m_preload == MediaPlayer::None && m_initialPreload == MediaPlayer::Auto) {
> 
> I think it may be theoretically possible that you would access m_initialPreload uninitialized. Perhaps you should check for m_preloadSet here also?

Oh yes good point. I'll check this issue and update the patch. Thanks for the feedback!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.