[Webkit-unassigned] [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90880


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152994|review?                     |review+
               Flag|                            |




--- Comment #54 from Pavel Feldman <pfeldman at chromium.org>  2012-07-18 06:18:01 PST ---
(From update of attachment 152994)
View in context: https://bugs.webkit.org/attachment.cgi?id=152994&action=review

Please fix OwnPtr nits prior to landing.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:533
> +    if (m_highlightData) {

// FIXME: Clear entire highlight data here, store config upon setInspectModeEnabled

> Source/WebCore/inspector/DOMNodeHighlighter.h:96
> +    void setHighlightData(PassOwnPtr<HighlightData>);

I.e. highlightNode will merge with the setHighlightData.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:985
> +        m_overlay->highlightNode(node);

You should pass m_inspectModeHighlightData here (in the subsequent change).

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1009
> +    HighlightData* highlightData = new HighlightData();

You should always adoptPtr upon creation.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1029
> +    HighlightData* highlightData = new HighlightData();

ditto

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1054
> +        HighlightData* highlightData = new HighlightData();

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.