[Webkit-unassigned] [Bug 89840] [WK2][EFL] Implement accelerated compositing on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89840





--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-18 03:41:33 PST ---
(From update of attachment 152931)
View in context: https://bugs.webkit.org/attachment.cgi?id=152931&action=review

> Source/WebKit2/PlatformEfl.cmake:51
> +    UIProcess/API/efl/ViewportProcessor.cpp

Nit: Upper-case file has placed above lower-case file.

> Source/WebKit2/PlatformEfl.cmake:145
> +    ${OPENGL_LIBRARIES}

Nit : It looks OPENGL_LIBRARIES needs to be moved to above SQLITE_LIBRARIES for alphabetical order.

> Source/WebKit2/PlatformEfl.cmake:161
> +    ${OPENGL_LIBRARIES}

ditto.

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:54
> +    page()->pageGroup()->preferences()->setAcceleratedDrawingEnabled(true);

Is it better to use m_page instead of page() ? Is there any reason ?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:296
> +#if USE(UI_SIDE_COMPOSITING)

Why do you use this macro function inside? Is this public API? I think we have to use macro function outside except for public APIs.

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:109
> +    virtual void didChangeContentsSize(const WebCore::IntSize&);

Don't you need to use USE(UI_SIDE_COMPOSITING) as well ?

> Source/WebKit2/UIProcess/API/efl/ViewportProcessor.cpp:67
> +    // adjust VisibleContentRect

Nit : s/adjust/Adjust/g

> Source/WebKit2/UIProcess/API/efl/ViewportProcessor.h:47
> +    ViewportProcessor(PageClientImpl*);

Use *explicit* keyword.

> Source/WebKit2/UIProcess/API/efl/ViewportProcessor.h:51
> +    float m_scaleFactor;

Nit : I think it is better to move to below m_viewportSize because of gathering similar type variables.

> Tools/MiniBrowser/efl/CMakeLists.txt:33
> +    ${OPENGL_LIBRARIES}

ditto.

> Tools/WebKitTestRunner/PlatformEfl.cmake:46
> +    ${OPENGL_LIBRARIES}

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.