[Webkit-unassigned] [Bug 91580] [WK2][EFL] Add a common code using Color instead of QColor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91580





--- Comment #5 from YoungTaeck Song <youngtaeck.song at samsung.com>  2012-07-18 01:58:24 PST ---
(In reply to comment #3)
> (From update of attachment 152924 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review
> 
> > Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149
> > +#if PLATFORM(QT)
> >          textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform);
> > +#else
> > +        textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform);
> > +#endif
> 
> I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :)

Thank you for kind review.
There is no Color::red in Color.h. So I used Color(0xFF, 0, 0).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.