[Webkit-unassigned] [Bug 91580] [WK2][EFL] Add a common code using Color instead of QColor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91580


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152924|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2012-07-18 00:33:38 PST ---
(From update of attachment 152924)
View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149
> +#if PLATFORM(QT)
>          textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform);
> +#else
> +        textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform);
> +#endif

I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.