[Webkit-unassigned] [Bug 90375] Parallel image decoders

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90375





--- Comment #29 from Kwang Yul Seo <skyul at company100.net>  2012-07-17 22:46:27 PST ---
(In reply to comment #27)
> (From update of attachment 151429 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151429&action=review
> 
> > Source/WebCore/platform/graphics/BitmapImage.cpp:272
> > +        m_isCachingFrame = true;
> 
> Would appreciate if you can explain more about the use of this flag. I can't find other use of this member variable outside of this method.

After we changed the condition for needToCache as in the following:

270     bool needToCache = index >= m_frames.size() || !m_frames[index].m_frame || !m_frames[index].m_isComplete;

cacheFrame(index) in BitmapImage::ensureFrameIsCached() now can recursively call BitmapImage::ensureFrameIsCached(). For example, 

BitmapImage::didReceiveFrameAtIndex
-> BitmapImage::checkForSolidColor (ImageQt.cpp)
-> BitmapImage::frameAtIndex
-> BitmapImage::ensureFrameIsCached

So we added m_isCachingFrame as a guard to return in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.